translate/upsert: use emit_column_or_rowid for DO UPDATE row snapshot#6118
Merged
PThorpe92 merged 4 commits intotursodatabase:mainfrom Mar 25, 2026
Merged
Conversation
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
Contributor
Author
|
could someone please help rerun the failed CI jobs for this PR? I believe the failures are infra/flaky |
This reverts commit 3cb0ac4.
PThorpe92
force-pushed
the
fix/upsert-added-column-default-compat
branch
from
b2a4ae2 to
1b65689
Compare
Collaborator
|
@ongyimeng you can ignore the sync and FK test failures. We know about them and they're being worked on. One of the snapshot tests was failing on main yesterday, but it was fixed a few hours ago, so rebasing on main should help. |
Collaborator
|
hey @ongyimeng I fixed the conflicts and pushed, should be good to go as soon as CI passes. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and context
Issue #6087
Description of AI Usage
Used AI to trace the issue to upsert.rs, propose the minimal fix, and draft the regression test.